Skip to content

Replaces uses of tfresource.SetLastError with retry.SetLastError #45350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 89 commits into
base: td-tfresource-timedout
Choose a base branch
from
Open

Replaces uses of tfresource.SetLastError with retry.SetLastError #45350

wants to merge 89 commits into from
+561 −656

Conversation

@gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 2, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Replaces uses of tfresource.SetLastError with retry.SetLastError.

Relates #25602

@gdavison gdavison requested a review from a team as a code owner December 2, 2025 05:47
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/ecs Issues and PRs that pertain to the ecs service. service/emr Issues and PRs that pertain to the emr service. service/route53 Issues and PRs that pertain to the route53 service. service/configservice Issues and PRs that pertain to the configservice service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/rds Issues and PRs that pertain to the rds service. service/directconnect Issues and PRs that pertain to the directconnect service. service/codebuild Issues and PRs that pertain to the codebuild service. service/gamelift Issues and PRs that pertain to the gamelift service. service/lightsail Issues and PRs that pertain to the lightsail service. service/acm Issues and PRs that pertain to the acm service. service/redshift Issues and PRs that pertain to the redshift service. service/firehose Issues and PRs that pertain to the firehose service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/organizations Issues and PRs that pertain to the organizations service. service/storagegateway Issues and PRs that pertain to the storagegateway service. service/ssm Issues and PRs that pertain to the ssm service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/appsync Issues and PRs that pertain to the appsync service. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 2, 2025
@gdavison gdavison force-pushed the td-tfresource-timedout branch from f898f6d to 65c714b Compare December 3, 2025 04:20
@gdavison gdavison force-pushed the td-tfresource-setlasterror branch from 3cdfb51 to 7f2cae7 Compare December 3, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linter Pertains to changes to or issues with the various linters. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/bedrockagentcore Issues and PRs that pertain to the bedrockagentcore service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/comprehend Issues and PRs that pertain to the comprehend service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/controltower Issues and PRs that pertain to the controltower service. service/datasync Issues and PRs that pertain to the datasync service. service/datazone Issues and PRs that pertain to the datazone service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dms Issues and PRs that pertain to the dms service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ecs Issues and PRs that pertain to the ecs service. service/eks Issues and PRs that pertain to the eks service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. service/firehose Issues and PRs that pertain to the firehose service. service/fsx Issues and PRs that pertain to the fsx service. service/gamelift Issues and PRs that pertain to the gamelift service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/iot Issues and PRs that pertain to the iot service. service/kafka Issues and PRs that pertain to the kafka service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/kendra Issues and PRs that pertain to the kendra service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/lambda Issues and PRs that pertain to the lambda service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/lexv2models Issues and PRs that pertain to the lexv2models service. service/lightsail Issues and PRs that pertain to the lightsail service. service/m2 Issues and PRs that pertain to the m2 service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/notifications Issues and PRs that pertain to the notifications service. service/observabilityadmin Issues and PRs that pertain to the observabilityadmin service. service/opensearch Issues and PRs that pertain to the opensearch service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/organizations Issues and PRs that pertain to the organizations service. service/osis Issues and PRs that pertain to the osis service. service/pipes Issues and PRs that pertain to the pipes service. service/qldb Issues and PRs that pertain to the qldb service. service/quicksight Issues and PRs that pertain to the quicksight service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. service/route53domains Issues and PRs that pertain to the route53domains service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/securityhub Issues and PRs that pertain to the securityhub service. service/securitylake Issues and PRs that pertain to the securitylake service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/signer Issues and PRs that pertain to the signer service. service/ssm Issues and PRs that pertain to the ssm service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. service/storagegateway Issues and PRs that pertain to the storagegateway service. service/synthetics Issues and PRs that pertain to the synthetics service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gdavison